[LLDB][PDB] Relax check for resolving breakpoint #169932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@llvm/pr-subscribers-lldb Author: nerix (Nerixyz) ChangesThe test was flaky, because it assumed that the breakpoint was always resolved before Full diff: https://github.com/llvm/llvm-project/pull/169932.diff 1 Files Affected:
diff --git a/lldb/test/Shell/SymbolFile/PDB/add-symbols.cpp b/lldb/test/Shell/SymbolFile/PDB/add-symbols.cpp
index ef7690b1720a6..64fbc84a98f24 100644
--- a/lldb/test/Shell/SymbolFile/PDB/add-symbols.cpp
+++ b/lldb/test/Shell/SymbolFile/PDB/add-symbols.cpp
@@ -25,7 +25,7 @@
// CHECK-NEXT: Breakpoint 1: no locations (pending).
// CHECK: (lldb) target symbols add
// CHECK: 1 location added to breakpoint 1
-// CHECK: (lldb) r
+
// CHECK: * thread #1, stop reason = breakpoint 1.1
// CHECK: (lldb) target variable a
// CHECK-NEXT: (A) a = (x = 47)
|
Contributor
Author
|
I'll merge this without a review, because the buildbot is currently failing (see linked comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test was flaky, because it assumed that the breakpoint was always resolved before
rwas executed (#169728 (comment)). This PR removes the check for this order. It still checks that the breakpoint is resolved before it is hit.